Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Fix CodeCov Paths #2566

Merged
merged 3 commits into from
Oct 27, 2020
Merged

housekeeping: Fix CodeCov Paths #2566

merged 3 commits into from
Oct 27, 2020

Conversation

worldbeater
Copy link
Contributor

@worldbeater worldbeater commented Oct 27, 2020

What kind of change does this PR introduce?

This PR updates the ci-build.yml file with the new parameters coming from reactiveui/ReactiveUI.Validation#156 With this PR, we are getting rid of node, dotnet-reportgenerator and npm, we are invoking codecov bash script now. This PR also updates the codecov paths from the old format a/ReactiveUI/ReactiveUI/src/ReactiveUI/VariadicTemplates.cs to the new format src/ReactiveUI/VariadicTemplates.cs, this should fix potential issues with paths.

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #2566 into main will increase coverage by 5.71%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2566      +/-   ##
==========================================
+ Coverage   57.94%   63.66%   +5.71%     
==========================================
  Files         127      129       +2     
  Lines        4580     4612      +32     
  Branches      684        0     -684     
==========================================
+ Hits         2654     2936     +282     
- Misses       1664     1676      +12     
+ Partials      262        0     -262     
Impacted Files Coverage Δ
...eactiveUI/Platforms/windows-common/ReactivePage.cs
...ReactiveUI/src/ReactiveUI/Mixins/ChangeSetMixin.cs
...I/ReactiveUI/src/ReactiveUI/Mixins/CompatMixins.cs
...tiveUI/src/ReactiveUI.XamForms/ReactiveTextCell.cs
...iveUI/src/ReactiveUI.XamForms/AutoSuspendHelper.cs
...c/ReactiveUI/Bindings/Converter/StringConverter.cs
...iveUI/src/ReactiveUI.XamForms/ViewModelViewHost.cs
...veUI/src/ReactiveUI.XamForms/ReactiveSwitchCell.cs
...ReactiveUI/Comparers/ComparerChainingExtensions.cs
...I/src/ReactiveUI/Routing/RoutableViewModelMixin.cs
... and 246 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a00d7c0...a5ef4fb. Read the comment docs.

@worldbeater worldbeater marked this pull request as ready for review October 27, 2020 18:08
@glennawatson glennawatson merged commit a5049fe into main Oct 27, 2020
@glennawatson glennawatson deleted the update-github-actions branch October 27, 2020 20:34
kronic pushed a commit to kronic/ReactiveUI that referenced this pull request Nov 16, 2020
* housekeeping: Fix codecov Paths

* Remove Node

* Configure coverlet-msbuild as in RxUI.Validation
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants