winforms view hosts

[rikbosch]

Hi,

I've added a winforms ViewModelViewHost and RoutedViewHost using the xaml project as example.

I've also included a set of tests for both controls.

This should make it easier to host viewmodels in a Windows Forms app.

[anaisbetts]

Can you put these ⬆️

[anaisbetts]

Hey @rikbosch, this looks rad! Your editor has run rampant with the style though, do you mind fixing these up? I've annotated one of the files thoroughly with the kinds of things to look for

[rikbosch]

I've made some changes to the styling. (CleanUp code using ReSharper).

One thing though about the functionality:

The routed viewhosts disposes the previous view when routers current viewmodel changes.
However, when registering the views as 'constant', this will not give the desired result, as the view will already be disposed when navigating back. Not disposing views will however potentially create a memoryleak.

Do you know what the behavior should be?
Some other MVVM frameworks have contracts in the like of IActivate and IDeactivate, which can be used to cleanup resources / temporary disable eventhandlers when a view is not active, e.g. not the router's current view.

[anaisbetts]

Do you know what the behavior should be?

I think in the WinForms case, you should never register views as constant, especially since they are HWND-based - we should definitely trash them when not visible.

Some other MVVM frameworks have contracts in the like of IActivate and IDeactivate, which can be used to cleanup resources / temporary disable eventhandlers when a view is not active, e.g. not the router's current view.

This is Coming Soon™ to ReactiveUI :)