Add minimal WPF sample #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I actually wanted to create this as a draft but I clicked too fast, sorry about that. |
schnerring
force-pushed
the
wpf-sample
branch
from
e1b83a0
to
419f1ae
Compare
Signed-off-by: Michael Schnerring <3743342+schnerring@users.noreply.github.com>
|
@schnerring Thanks for the contribution. I will take a look at it later this week. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
=======================================
Coverage 62.13% 62.13%
=======================================
Files 27 27
Lines 676 676
Branches 82 82
=======================================
Hits 420 420
Misses 226 226
Partials 30 30 ☔ View full report in Codecov by Sentry. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Xamarin.Forms has preview support for the Windows Presentation Foundation (WPF), so I've created a minimal sample project that partially works.
What is the current behavior?
There's no WPF sample / support (see #47)
What is the new behavior?
Added WPF sample that does not fully work. The navigation bar is blank.
What might this PR break?
Nothing if WPF related changes are decoupled from the rest of the project.
Please check if the PR fulfills these requirements
Other information:
How to get started with #47? I suppose we'd need to add a platform specific implementation of
NavigationViewfor WPF? I have briefly looked at ReactiveUI'sTransitioningContentControlbut don't understand how to base the solution off that control