-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minimal WPF sample #325
Conversation
I actually wanted to create this as a draft but I clicked too fast, sorry about that. |
e1b83a0
to
419f1ae
Compare
Signed-off-by: Michael Schnerring <3743342+schnerring@users.noreply.github.com>
@schnerring Thanks for the contribution. I will take a look at it later this week. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
=======================================
Coverage 62.13% 62.13%
=======================================
Files 27 27
Lines 676 676
Branches 82 82
=======================================
Hits 420 420
Misses 226 226
Partials 30 30 ☔ View full report in Codecov by Sentry. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What kind of change does this PR introduce?
Xamarin.Forms has preview support for the Windows Presentation Foundation (WPF), so I've created a minimal sample project that partially works.
What is the current behavior?
There's no WPF sample / support (see #47)
What is the new behavior?
Added WPF sample that does not fully work. The navigation bar is blank.
What might this PR break?
Nothing if WPF related changes are decoupled from the rest of the project.
Please check if the PR fulfills these requirements
Other information:
How to get started with #47? I suppose we'd need to add a platform specific implementation of
NavigationView
for WPF? I have briefly looked at ReactiveUI'sTransitioningContentControl
but don't understand how to base the solution off that control