Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping: Fix CodeCov Paths #107

Merged
merged 1 commit into from
Oct 27, 2020
Merged

housekeeping: Fix CodeCov Paths #107

merged 1 commit into from
Oct 27, 2020

Conversation

worldbeater
Copy link
Contributor

@worldbeater worldbeater commented Oct 27, 2020

What kind of change does this PR introduce?

This PR should fix the broken codecov paths. We are now using the newer GitHub Actions CI configuration coming from reactiveui/ReactiveUI.Validation#156 e.g. we are getting rid of node, npm, and dotnet reportgenerator. The coverage increases due to opencover-cobertura format change.

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #107 into main will increase coverage by 4.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
+ Coverage   62.87%   67.22%   +4.34%     
==========================================
  Files           6        6              
  Lines         299      299              
  Branches       51        0      -51     
==========================================
+ Hits          188      201      +13     
  Misses         98       98              
+ Partials       13        0      -13     
Impacted Files Coverage Δ
...hclock/punchclock/src/Punchclock/KeyedOperation.cs
...chclock/src/Punchclock/OperationQueueExtensions.cs
...hclock/punchclock/src/Punchclock/OperationQueue.cs
...chclock/src/Punchclock/PrioritySemaphoreSubject.cs
...chclock/punchclock/src/Punchclock/PriorityQueue.cs
...lock/punchclock/src/Punchclock/ScheduledSubject.cs
src/Punchclock/ScheduledSubject.cs 0.00% <0.00%> (ø)
src/Punchclock/KeyedOperation.cs 83.33% <0.00%> (ø)
src/Punchclock/PriorityQueue.cs 88.31% <0.00%> (ø)
src/Punchclock/OperationQueue.cs 86.51% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46f71d8...332848e. Read the comment docs.

@worldbeater worldbeater marked this pull request as ready for review October 27, 2020 20:10
@worldbeater
Copy link
Contributor Author

worldbeater commented Oct 27, 2020

According to the following link, codecov now resolves the paths properly for punchclock https://codecov.io/gh/reactiveui/punchclock/src/332848e189cd2bd1bcd1dc5f3eb0f671f482a086/src/Punchclock/OperationQueue.cs

Codecov
Hosted coverage report highly integrated with GitHub, Bitbucket and GitLab. Awesome pull request comments to enhance your QA.

@glennawatson glennawatson merged commit ff035e4 into main Oct 27, 2020
@glennawatson glennawatson deleted the fix-codecov-paths branch October 27, 2020 20:37
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants