Added methods to support creating RefitSettings using the service provider #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
What is the current behavior?
Currently it is not possible to influence refit settings using other services in the
IServiceProviderand everything must be know ahead of time. This isn't always ideal or possible.What is the new behavior?
Two new overloads have been added to
AddRefitClientthat takeFunc<IServiceProvider, RefitSettings?>? settingsAction. This is resolved as a singleton when requesting the other related services.What might this PR break?
Hopefully nothing! Unit tests have been added that cover the new functionality as well as the existing functionality, ensuring that all the services are registered as expected, and the typed service client can properly be resolved.
Please check if the PR fulfills these requirements
Other information:
Fixes: #903