Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactor code formatting for better readability #1564

Merged

Conversation

msadeqsirjani
Copy link
Contributor

@msadeqsirjani msadeqsirjani commented Sep 13, 2023

What kind of change does this PR introduce?
This PR introduces a code formatting change. It reformats the code to improve its readability by adjusting the indentation of the LINQ query, making it more consistent with coding standards.

What is the current behavior?
The current behavior of the code is that it uses inconsistent indentation in the LINQ query.

What is the new behavior?
The new behavior of the code is that it uses consistent and improved indentation in the LINQ query, making it more readable and aligned with coding standards.

What might this PR break?
This PR is unlikely to break any functionality or introduce bugs since it focuses on code formatting changes that do not affect the logic or behavior of the code.

Please check if the PR fulfills these requirements:

  • Tests for the changes have been added (for bug fixes/features).
  • Docs have been added/updated (for bug fixes/features).

Reformatted the code to improve its readability by adjusting the indentation of the LINQ query, making it more consistent with coding standards.
@glennawatson
Copy link
Contributor

I think the other benefit is just one less method invocation, so will merge this one if the build likes it.

@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (df6b7a9) 90.08% compared to head (4ac49f9) 90.08%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1564   +/-   ##
=======================================
  Coverage   90.08%   90.08%           
=======================================
  Files          33       33           
  Lines        1685     1685           
=======================================
  Hits         1518     1518           
  Misses        167      167           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glennawatson glennawatson merged commit e726d19 into reactiveui:main Oct 1, 2023
3 checks passed
@msadeqsirjani msadeqsirjani deleted the refactor/code-formatting branch October 1, 2023 04:40
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants