Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating #811 fix with better language detection #815

Merged
merged 3 commits into from
Dec 20, 2019

Conversation

jamiehowarth0
Copy link
Member

What kind of change does this PR introduce?
Instead of checking for a csproj file extension, this checks for the project's language, a more robust check for compiling the Refit stubs.

What is the current behavior?
In VB.NET and F# projects (see #811), Refit attempts to compile Refitstubs.g.cs, resulting in a build error

What is the new behavior?
See PR change details

What might this PR break?
Nothing

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

@jamiehowarth0 jamiehowarth0 merged commit c7d3740 into reactiveui:master Dec 20, 2019
@lock lock bot locked and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant