Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable deterministic builds #873

Merged
merged 9 commits into from
Mar 29, 2020
Merged

Enable deterministic builds #873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c9df42c
Enable deterministic builds
clairernovotny Mar 28, 2020
aad713e
Use preview SDK with fixes
clairernovotny Mar 28, 2020
5f2e57d
Install .NET Core first
clairernovotny Mar 28, 2020
9e65c1e
Update Directory.build.props
clairernovotny Mar 29, 2020
7f64b51
Create Directory.Build.targets
clairernovotny Mar 29, 2020
2a93afb
Delete global.json
clairernovotny Mar 29, 2020
fbea387
Update azure-pipelines.yml
clairernovotny Mar 29, 2020
782d854
Update azure-pipelines.yml
clairernovotny Mar 29, 2020
4c52a95
disable deterministic for test project
clairernovotny Mar 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<!-- Workaround. Remove once we're on 3.1.300+
https://github.com/dotnet/sourcelink/issues/572 -->
<Project>
<PropertyGroup>
<TargetFrameworkMonikerAssemblyAttributesPath>$([System.IO.Path]::Combine('$(IntermediateOutputPath)','$(TargetFrameworkMoniker).AssemblyAttributes$(DefaultLanguageSourceExtension)'))</TargetFrameworkMonikerAssemblyAttributesPath>
</PropertyGroup>
<ItemGroup>
<EmbeddedFiles Include="$(GeneratedAssemblyInfoFile)"/>
</ItemGroup>
</Project>
10 changes: 6 additions & 4 deletions Directory.build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,19 +16,21 @@
<LangVersion>latest</LangVersion>
<EmbedUntrackedSources>true</EmbedUntrackedSources>
<PublishRepositoryUrl>true</PublishRepositoryUrl>

<AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)buildtask.snk</AssemblyOriginatorKeyFile>
<SignAssembly>true</SignAssembly>
</PropertyGroup>

<PropertyGroup Condition="'$(TF_BUILD)' == 'true'">
<ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
<Deterministic>true</Deterministic>
</PropertyGroup>

<ItemGroup Condition="'$(IsTestProject)' != 'true' and '$(SourceLinkEnabled)' != 'false'">
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All"/>
</ItemGroup>
<ItemGroup Condition="'$(IsTestProject)' != 'true'">
<PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="16.5.132" PrivateAssets="All" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All"/>
<PackageReference Include="Nerdbank.GitVersioning" Version="3.1.71" PrivateAssets="all" />
</ItemGroup>

Expand Down
1 change: 1 addition & 0 deletions Refit.Tests/Refit.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

<PropertyGroup>
<TargetFrameworks>net461;netcoreapp2.1;netcoreapp3.1</TargetFrameworks>
<Deterministic>false</Deterministic> <!-- Some tests rely on CallerFilePath -->
</PropertyGroup>

<ItemGroup>
Expand Down
14 changes: 7 additions & 7 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@ stages:
BuildConfiguration: Release

steps:
- task: UseDotNet@2
displayName: Use .NET Core 3.1.x SDK
inputs:
version: 3.1.x
performMultiLevelLookup: true

- task: DotNetCoreCLI@2
inputs:
command: custom
Expand All @@ -40,12 +46,6 @@ stages:
- script: nbgv cloud
displayName: Set Version

- task: UseDotNet@2
displayName: Use .NET Core 3.1.x SDK
inputs:
version: 3.1.x
performMultiLevelLookup: true

- task: DotNetCoreCLI@2
inputs:
command: build
Expand Down Expand Up @@ -138,4 +138,4 @@ stages:

- publish: $(Pipeline.Workspace)/BuildPackages
displayName: Publish Signed Packages
artifact: SignedPackages
artifact: SignedPackages