Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation and examples for the ApiResponse<T> return type. #893

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

sidm1983
Copy link

@sidm1983 sidm1983 commented Apr 7, 2020

What kind of change does this PR introduce?
Adds documentation about the ApiResponse<T> return type and shows examples on how to retrieve response meta data (like response headers and status code) from this return type. I have added this documentation in response to the question I asked in the "Issues" section. This PR fixes #872

What is the current behavior?
Documentation about this particular return type doesn't exist.

What is the new behavior?
Documentation for this return type has been added.

What might this PR break?
It won't break anything

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:
None

@dnfclas
Copy link

dnfclas commented Apr 7, 2020

CLA assistant check
All CLA requirements met.

@clairernovotny clairernovotny merged commit 3d6a764 into reactiveui:master Apr 8, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: Nothing in the documentation about Task<ApiResponse<T>> return type?
4 participants