Fix query collection format inside object #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes #894
What is the current behavior?
a) If query attribute is present on query object property, value is simply converted ToString.
b)
CollectionFormat(both inRefitSettingsand inQueryAttribute) is ignored when used on query object property. Interesting enough, it differs depending on item type - for enum or int it is Csv (because that is default), for object - Multi (because that how it is defined inBuildQueryMapmethod - no idea why).What is the new behavior?
a) Value is formatted to string only when explicit Format is defined in Query attribute.
b) Collections in query objects are formatted same as regular query collections - accounting for CollectionFormat in RefitSettings and in QueryAttribute.
What might this PR break?
Please check if the PR fulfills these requirements
Other information:
Extracted part with collection values formatting from
ParseQueryParameterto separate methodParseEnumerableQueryParameterValueto be able to reuse inside ofBuildQueryMap.Also updated RequestBuilder tests to use nameof for method names - much easier to see where particular method is used, hope you don't mind.