Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support partial interfaces #899

Merged
merged 2 commits into from
Sep 3, 2020
Merged

Support partial interfaces #899

merged 2 commits into from
Sep 3, 2020

Conversation

Dreamescaper
Copy link
Contributor

What kind of change does this PR introduce?
Fixes #471

What is the current behavior?
Generated stubs are invalid if I have partial interfaces.

What is the new behavior?
Info about partial interfaces is merged into one, therefore generated file is valid.

What might this PR break?

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:
Original issue is closed in favor of interface inheritance, but I'd like to use partial interfaces on my project, and it was quite easy to implement, so I decided to give it a go.

@clairernovotny clairernovotny merged commit e79957e into reactiveui:master Sep 3, 2020
@Dreamescaper Dreamescaper deleted the support_partial_interfaces branch September 3, 2020 15:25
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using an interface that is spread over multiple files (partial interfaces), Refit breaks
2 participants