Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 617 (support EnumMember on enums within types for query string param objects) #968

Merged
merged 2 commits into from
Sep 3, 2020

Conversation

todthomson
Copy link
Contributor

What kind of change does this PR introduce?

Bug fix.

What is the current behavior?

See: #617.

What is the new behavior?

Query string paramter types that have enum properties will respect [EnumMember(Value = "foo")].

i.e. Not just "direct parameter enums", but where your types have enum properties (see 617 for the example code).

What might this PR break?

I don't think it will break anything, as I have:

  • Included appropriate passing tests.
  • Checked that it doesn't break any existing tests.
  • Should not break existing code (unless in the slim chance that they have types with enums for query string parameters which already have EnumMember on them, where that is currently achieving nothing, which would be "strange", but sadly not impossible...).

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added / updated (for bug fixes / features).

Other information:

None.

@dnfadmin
Copy link

dnfadmin commented Aug 29, 2020

CLA assistant check
All CLA requirements met.

@clairernovotny clairernovotny merged commit f639869 into reactiveui:master Sep 3, 2020
@todthomson todthomson deleted the fix-issue-617 branch October 28, 2020 01:40
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants