Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translating forms.md #22

Closed
wants to merge 11 commits into from

Conversation

@SahibArora
Copy link

commented Mar 6, 2019

Hi there,
Sorry I started working on it, before your reply, just a little bit excited towards my first open source contribution. Hope you don't mind.
I am just opening a PR request for forms which I will be updating with time. When I will be done, I will let you know.

Thank you,

@netlify

This comment has been minimized.

Copy link

commented Mar 6, 2019

Deploy preview for hi-reactjs ready!

Built with commit f0cc6df

https://deploy-preview-22--hi-reactjs.netlify.com

Sahib
@tesseralis tesseralis referenced this pull request Mar 6, 2019
8 of 88 tasks complete
@arshadkazmi42
Copy link
Member

left a comment

Good start.
I have left a few comments, let's fix all those feedback reviews first before continuing with further translations of page

Please read #23 before working on the review fixes

content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
Sahib
@SahibArora

This comment has been minimized.

Copy link
Author

commented Mar 7, 2019

Hi there,

Thanks for the suggestions.
I did the changes, you asked me.
Please give it a look and then I will continue further.

Thanks,

content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
@arshadkazmi42
Copy link
Member

left a comment

Great progress.
Added some more comments and you have missed few of the previous suggestions

Sahib
@SahibArora

This comment has been minimized.

Copy link
Author

commented Mar 8, 2019

I did the changes, thanks for your suggestions again.
I will carry on with the translating.
Thanks!

@arshadkazmi42

This comment has been minimized.

Copy link
Member

commented Mar 20, 2019

@SahibArora There is one line left for translation line 30, once you can do the translation of that line, I can review and approve it for second round of review.

@arshadkazmi42

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

@SahibArora Any updates on this? Let us know if you need any help from our end

@arshadkazmi42

This comment has been minimized.

Copy link
Member

commented Apr 21, 2019

@SahibArora Any updates on this? Let us know if you need any help from our end

@arshadkazmi42

This comment has been minimized.

Copy link
Member

commented May 5, 2019

@SahibArora Any updates?

@saranshkataria

This comment has been minimized.

Copy link
Member

commented May 20, 2019

@SahibArora please let us know if you will be working on this?

@SahibArora

This comment has been minimized.

Copy link
Author

commented May 20, 2019

Hi @arshadkazmi42,
I apologize for the delay and not been able to follow-up to your past messages.
I will go through it right away and submit the file as soon as possible.
Sorry again for the inconvenience caused because of me.

@saranshkataria

This comment has been minimized.

Copy link
Member

commented May 20, 2019

@SahibArora no worries. Just wanted to ensure that you will complete it. Let us know if you need any help

@saranshkataria

This comment has been minimized.

Copy link
Member

commented Jun 14, 2019

@SahibArora any updates?

@saranshkataria

This comment has been minimized.

Copy link
Member

commented Aug 18, 2019

Closing this PR due to inactivity. Feel free to reopen if you are going to work on it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.