Skip to content

Conversation

junghyeonsu
Copy link
Contributor

@junghyeonsu junghyeonsu commented Dec 2, 2020

Progress

고쳐야 하는 부분이 있다면 리뷰 부탁드립니다!

@netlify
Copy link

netlify bot commented Dec 2, 2020

Deploy preview for ko-reactjs-org ready!

Built with commit 01ce6ee

https://deploy-preview-268--ko-reactjs-org.netlify.app

Copy link
Member

@taehwanno taehwanno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI를 살펴보니 prettier 적용이 제대로 안된거 같아요! 포맷팅 정리 부탁드릴게용

Co-authored-by: Taehwan Noh <taehwanno.dev@gmail.com>
Co-authored-by: Taehwan Noh <taehwanno.dev@gmail.com>
@junghyeonsu
Copy link
Contributor Author

@taehwanno 리뷰 감사합니다! 한 가지 질문이 있습니다!
prettier를 어떻게 제대로 적용하는 지 잘 모르겠습니다.😢
조언 주시면 감사하겠습니다!

@taehwanno
Copy link
Member

taehwanno commented Dec 7, 2020

package.json에 prettier 명령어가 있어서 실행해주시면 됩니다 ㅎㅎ 제가 직접해서 푸쉬해뒀어요!
prettier는 Code formatter인데 코드 포맷팅(줄 간격, 라인 최대 길이 등)을 자동으로 맞춰주는 도구라 생각하시면 됩니다.

Copy link
Member

@taehwanno taehwanno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨어요!

@taehwanno taehwanno merged commit e4b8fe0 into reactjs:master Dec 7, 2020
@junghyeonsu
Copy link
Contributor Author

정말 감사하고 친절함에 감동했습니다👍
감사하고 고생하셨습니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants