Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a means of filtering errors #34

Closed
kloots opened this issue May 20, 2015 · 2 comments · Fixed by #36
Closed

Provide a means of filtering errors #34

kloots opened this issue May 20, 2015 · 2 comments · Fixed by #36

Comments

@kloots
Copy link
Collaborator

kloots commented May 20, 2015

If you use react-a11y on an existing project, you'll likely be overwhelmed by the number of accessibility errors. It'd be useful to have a means of filtering errors by component name, so developers can easily focus on addressing failures on a per-component basis.

kloots pushed a commit that referenced this issue May 20, 2015
…. Provide a means of logging DOM element references (fixes #35).
@kloots
Copy link
Collaborator Author

kloots commented May 20, 2015

Here's the approach I came up with:

#36

On Wed, May 20, 2015 at 11:30 AM, Asa Ayers notifications@github.com
wrote:

oh, are you talking about component name being

and not
?


Reply to this email directly or view it on GitHub
#34 (comment).

@AsaAyers
Copy link
Contributor

Sorry, I didn't notice who made the issue and I replied without reading the other notifications :(

Great job finding a solution! I looked at the code a bit and it sounds great. Much better than what I came up with :)

angus-c added a commit that referenced this issue May 20, 2015
Add a means of filtering failures on a per-component basis (fixes #34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants