-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unwind recursion in loopAsync when possible #2923
Conversation
cc @mhart |
This is a huge win for me – cut the stacks in our profiling down by at least 25% – and we only have 20 routes, so those with more routes will see even more benefits. Thanks! |
Great, thanks. I'll let this sit a little more in case there are any more comments – we can't cut the next React Router RC without a new history RC anyway. |
Not sure why coveralls isn't coming back OK, but this looks good to me. |
Unwind recursion in loopAsync when possible
@timdorr would you be up for back porting this to 1.0.x? I bumped into an |
I'm not sure of our policy on patches for 1.0, but a PR would certainly make it more likely to happen 😄 |
I don't think we should – 2.x is essentially backward compatible. |
@gcorne I'm not sure of your particular use case, but @taion is right and upgrading should be painless. Just bump the version and start hunting for deprecation warnings. You can automate that with codemods too: https://github.com/reactjs/rackt-codemod |
For #2922