-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: replace broken Placekitten placeholder images with Loremflickr #6927
Fix: replace broken Placekitten placeholder images with Loremflickr #6927
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @aaron-mota! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Signed the CLA. Waiting for that to take effect and will rerun the GAs UPDATE: not sure when it's going to take effect... ("up to 1 hour" was 24 hours ago) |
…odebase for cat images)
Fixed by #7189 |
Description
Placekitten (cat placeholder images) seems to be down.
Changes Made
I've replaced the placekitten urls with loremflickr urls, another free placeholder image service that can supply cat images. It's already being used elsewhere within the codebase for cat images, and allows width and height parameters to be passed (so that the image dimensions of the original placeholders could be matched). This change could be used just temporarily if placekitten being down is also temporary.
Code of Conduct
This pull request adheres to the project's Code of Conduct.
Screenshots
(React docs) Example: Scrolling to an element
Before change (placekitten):
After change (loremflickr):
(React docs) Challenge: Scrolling an image carousel
Before change (placekitten):
After change (loremflickr):