Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: replace broken Placekitten placeholder images with Loremflickr #6927

Closed

Conversation

aaron-mota
Copy link

@aaron-mota aaron-mota commented Jun 2, 2024

Description

Placekitten (cat placeholder images) seems to be down.

Changes Made

I've replaced the placekitten urls with loremflickr urls, another free placeholder image service that can supply cat images. It's already being used elsewhere within the codebase for cat images, and allows width and height parameters to be passed (so that the image dimensions of the original placeholders could be matched). This change could be used just temporarily if placekitten being down is also temporary.

Code of Conduct

This pull request adheres to the project's Code of Conduct.

Screenshots

(React docs) Example: Scrolling to an element

  • Before change (placekitten):

    • CleanShot 2024-06-01 at 20 06 57@2x
  • After change (loremflickr):

    • CleanShot 2024-06-01 at 21 01 27

(React docs) Challenge: Scrolling an image carousel

  • Before change (placekitten):

    • CleanShot 2024-06-01 at 20 06 09@2x
  • After change (loremflickr):

    • CleanShot 2024-06-01 at 21 01 07

Copy link

vercel bot commented Jun 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
19-react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2024 1:59am
react-dev ✅ Ready (Inspect) Visit Preview Jun 2, 2024 1:59am

@facebook-github-bot
Copy link
Collaborator

Hi @aaron-mota!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@aaron-mota aaron-mota changed the title Replace Broken Placekitten Placeholder Images with Cataas Fix: replaced broken Placekitten placeholder images with Cataas Jun 2, 2024
@aaron-mota aaron-mota changed the title Fix: replaced broken Placekitten placeholder images with Cataas Fix: replace broken Placekitten placeholder images with Cataas Jun 2, 2024
Copy link

github-actions bot commented Jun 2, 2024

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@aaron-mota aaron-mota closed this Jun 2, 2024
@aaron-mota aaron-mota reopened this Jun 2, 2024
@aaron-mota
Copy link
Author

aaron-mota commented Jun 2, 2024

Signed the CLA. Waiting for that to take effect and will rerun the GAs

UPDATE: not sure when it's going to take effect... ("up to 1 hour" was 24 hours ago)

@aaron-mota aaron-mota closed this Jun 2, 2024
@aaron-mota aaron-mota reopened this Jun 2, 2024
@aaron-mota aaron-mota closed this Jun 2, 2024
@aaron-mota aaron-mota reopened this Jun 2, 2024
@aaron-mota aaron-mota changed the title Fix: replace broken Placekitten placeholder images with Cataas Fix: replace broken Placekitten placeholder images with Loremflickr Jun 2, 2024
@rickhanlonii
Copy link
Member

Fixed by #7189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants