Skip to content

Testing Shallow Renderer #1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

charBap
Copy link

@charBap charBap commented Jan 26, 2019

@facebook-github-bot
Copy link
Collaborator

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@reactjs-bot
Copy link

Deploy preview for reactjs ready!

Built with commit 851178f

https://deploy-preview-1597--reactjs.netlify.com

@alexkrolick
Copy link
Collaborator

@charBap Thank you for taking the time to start on this issue 😃. It looks like what you've written so far is about Enzyme, which is a third-party package. React has its own set of test utilities: react-test-renderer, react-test-renderer/shallow, react-dom/test-utils.

The existing docs are here:

And the source is here:

If you're still interested in updating the docs for these packages, you are welcome to, if not, what you have could make a good blog post.

@threepointone
Copy link
Contributor

We're moving away from recommending shallow rendering, so I'm going to close this. Thank you for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants