Replace should with must to denote that Suspense is not optional with React.lazy #2768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieDixon
changed the title
|
Deploy preview for reactjs ready! Built with commit 41a866d |
…React.lazy components
JamieDixon
force-pushed
the
suspense-optional
branch
from
e8e3eed to
41a866d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes there can be some confusion with the word "should" because it is often used to denote an optional operation.
In the case of
React.lazythe component must be a descendent of<Suspense>or a custom alternative. This PR changes the word "should" to "must" and includes a comment about using either Suspense or an alternative.See this StackOverflow question where the user assumed it to be optional because of the word "should": https://stackoverflow.com/questions/60342788/react-lazy-not-loading-any-components#60342841