Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta RFC: Clarify expectations about the RFC process #200

Merged
merged 7 commits into from
Sep 6, 2021
Merged

Meta RFC: Clarify expectations about the RFC process #200

merged 7 commits into from
Sep 6, 2021

Conversation

gaearon
Copy link
Member

@gaearon gaearon commented Aug 24, 2021 •
edited
Loading

Closes #182.

tl;dr

  • In practice, most merged RFCs come from the React team. Acknowledge this and explain why.
  • Clarify that the purpose of RFCs is not necessarily to get merged, but to spark a discussion that can inform later proposals.
  • Remove the commitment of timely reviews since in practice we aren't doing a good job at that.

I think this reflects how the RFC process works in practice, and being honest about it is probably better.

Rendered text

@gaearon gaearon mentioned this pull request Aug 24, 2021
Closed
bvaughn
bvaughn approved these changes Aug 24, 2021
View reviewed changes
Copy link
Collaborator

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this update

README.md Outdated Show resolved Hide resolved
README.md
authors are reading the discussions, so RFCs often lead to community experimentation and userland solutions.

We apply the same level of rigour both to React Team RFCs and Community RFCs. The primary difference
between them is in the design phase: React Team RFCs tend to be submitted at the end of the design
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This too 👍🏼

README.md

**React's RFC process owes its inspiration to the [Yarn RFC process], [Rust RFC process], and [Ember RFC process]**
React's RFC process owes its inspiration to the [Yarn RFC process], [Rust RFC process], and [Ember RFC process]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nit: Missing trailing puncuation

rickhanlonii
rickhanlonii approved these changes Aug 24, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
mAAdhaTTah
mAAdhaTTah reviewed Aug 25, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@gaearon @rickhanlonii @mAAdhaTTah
Apply suggestions from code review
b6acf84 
Co-authored-by: Ricky <rickhanlonii@gmail.com>
Co-authored-by: James DiGioia <jamesorodig@gmail.com>
@gaearon gaearon merged commit ef8c05b into main Sep 6, 2021
@gaearon gaearon mentioned this pull request Nov 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mAAdhaTTah mAAdhaTTah mAAdhaTTah left review comments

@bvaughn bvaughn bvaughn approved these changes

@rickhanlonii rickhanlonii rickhanlonii approved these changes

Assignees
No one assigned
Labels
CLA Signed react core team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improving the RFC workflow process
5 participants
@gaearon @bvaughn @rickhanlonii @mAAdhaTTah @facebook-github-bot