Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reparenting API #34

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Reparenting API #34

wants to merge 22 commits into from

Commits on Mar 12, 2018

  1. Introduce the RFC for the reparenting API

    @dantman
    dantman committed Mar 12, 2018
    Configuration menu
    Copy the full SHA
    9f8c4ce View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2018

  1. Fix interface definition.

    @dantman
    dantman committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    93103d5 View commit details
    Browse the repository at this point in the history

  2. Add a glossary and improve clarity of the design docs 

    Also add unresolved question about rendering the children of a detached dom tree.
    @dantman
    dantman committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    3f87f95 View commit details
    Browse the repository at this point in the history

  3. Add a limitations section and a request to avoid removeChild when mov… 

    …ing dom nodes
    @dantman
    dantman committed Mar 15, 2018
    Configuration menu
    Copy the full SHA
    bfc4430 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2018

  1. Confirm that focus is lost when reparenting 

    Tested in Chrome, Firefox, Safari, and IE11. All browsers lose focus on basic appendChild.
https://dantman.github.io/dom-reparent-tests/focus.html
    @dantman
    dantman committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    b947e8d View commit details
    Browse the repository at this point in the history

  2. Add some more detail on the goals of reparenting from the perspective… 

    … of this RFC
    @dantman
    dantman committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    5fe5fcd View commit details
    Browse the repository at this point in the history

  3. Update link to getSnapshotBeforeUpdate

    @dantman
    dantman committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    8435147 View commit details
    Browse the repository at this point in the history

  4. Fix spelling and markdown line break mistakes

    @dantman
    dantman committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    e6011c9 View commit details
    Browse the repository at this point in the history

  5. Add explanation of the requirements of any sufficent reparenting api

    @dantman
    dantman committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    f0808a7 View commit details
    Browse the repository at this point in the history

  6. Add unresolved question about reparents being sent upwards

    @dantman
    dantman committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    2dae0e9 View commit details
    Browse the repository at this point in the history

  7. Add a table cell example 

    This demonstrates the usage of dynamic reparent creation and removal, without the complex multi-component handling of the dynamic template example.
    @dantman
    dantman committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    02957e6 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2018

  1. Add a simple example of detachable trees

    @dantman
    dantman committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    6ece601 View commit details
    Browse the repository at this point in the history

  2. Add requirement that Portals are not the way reparents are used

    @dantman
    dantman committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    b4562d6 View commit details
    Browse the repository at this point in the history

  3. Add an alternatives section on a .keep() signal instead of explicit… 

    … `.unmount()`.

Also fix mistakes in the original Dynamic template example.
    @dantman
    dantman committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    71397fc View commit details
    Browse the repository at this point in the history

  4. Fix anchor link

    @dantman
    dantman committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    3645e2e View commit details
    Browse the repository at this point in the history

  5. Line wrap comments

    @dantman
    dantman committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    d7dd61d View commit details
    Browse the repository at this point in the history

  6. Fix small coding mistake in the layout example

    @dantman
    dantman committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    425c5ee View commit details
    Browse the repository at this point in the history

  7. Move the simple layout example to the top of the list of examples

    @dantman
    dantman committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    0a3b7d8 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2018

  1. Update RFC to propose .keep() instead of .unmount()

    @dantman
    dantman committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    c137d41 View commit details
    Browse the repository at this point in the history

  2. Update getSnapshotBeforeUpdate reference to link to the React documen… 

    …tation
    @dantman
    dantman committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    965ffaf View commit details
    Browse the repository at this point in the history

  3. Refactor code examples to use .keep() instead of .unmount()

    @dantman
    dantman committed Apr 23, 2018
    Configuration menu
    Copy the full SHA
    323de7b View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2018

  1. Fix examples and protocols to remove the this:Component 

    this:Component was part of the `.unmount()` API, it's no longer used in the `.keep()` api.
    @dantman
    dantman committed Jun 16, 2018
    Configuration menu
    Copy the full SHA
    1201e2d View commit details
    Browse the repository at this point in the history