Skip to content
This repository was archived by the owner on Apr 21, 2023. It is now read-only.

Conversation

gabimoncha
Copy link

This PR adds Romanian translations to Home Page #7 , Header, Footer and Docs and Community Navs

@gabimoncha gabimoncha mentioned this pull request Feb 24, 2019
88 tasks
@netlify
Copy link

netlify bot commented Feb 24, 2019

Deploy preview for ro-reactjs failed.

Built with commit 44a7eb8

https://app.netlify.com/sites/ro-reactjs/deploys/5e8ac88a7373a40007e9aba3

@tesseralis
Copy link
Contributor

@nikiciv this might be ready for a re-review?

@gabimoncha
Copy link
Author

gabimoncha commented Mar 17, 2019

@tesseralis @nikiciv - It would be great if we can merge this as I am waiting to continue work with the others.

@tesseralis
Copy link
Contributor

@gabrielmoncea you can start working on another page while this is in review!

@micnic
Copy link

micnic commented Mar 19, 2019

Hi, I would like to add some general rules to improve the translation to Romanian of the text in this commit (but these rules, I guess, could be used in the whole repo). First of all, I'm also a speaker of Russian and French, which are accepted already as finished translations, and based on my past experience in translating to Romanian, I recommend the following:

  1. Do not capitalize all the words in titles (It is common for English, not for Romanian), examples: Resurse Externe, Bănci de lucru pentru Componente, Trusă pentru Început. As I see some titles are capitalized, some - not, there should be a consistency.

  2. Do not translate all the notions to Romanian, in French translation Hooks are called Hooks, in Russian - Хуки (spelled as Hooky, to match "hook" + Russian plural termination), "Cârlig" / "Cârlige" does not sound that good, and can add some misunderstanding of those who will use the name based on Hook and those who will use it based on "Cârlig", in my opinion for this case "Hook" / "Hook-uri" will fit better.

@gabimoncha
Copy link
Author

@micnic thanks a lot for the review. We were thinking on making a list of terminology that we should keep as it is in English. It would be great if you could jump in :D

@tesseralis I will continue on this one to implement the review suggestions

@micnic
Copy link

micnic commented Mar 19, 2019

@gabrielmoncea will find some time, as I teach React, the documentation in Romanian would help students to understand it better in their native language. For now will follow the process of accepting of this PR.

- id: external-resources
title: External Resources
title: Resurse Externe
- title: Unelte
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S-ar putea ca sectiunea sa fie stearsa din master? @gabrielmoncea

title: Reguli ale Hook-urilor
- id: hooks-custom
title: Building Your Own Hooks
title: Construieste-ti propriul Hook
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aici am schimbat eu din Carlige in Hooks ca a fost conflict cu master-ul.. ma gandeam ca e putin mai ok. Ce parere aveti @gabrielmoncea @nikiciv ?

@raultomescu
Copy link
Contributor

@gabrielmoncea minor comment la sectiunea 'Unelte', s-ar putea sa nu mai existe in master. Otherwise LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants