-
Notifications
You must be signed in to change notification settings - Fork 14
RO translations for Home Page, Header, Footer and Docs and Community navs #94
base: main
Are you sure you want to change the base?
Conversation
Deploy preview for ro-reactjs failed. Built with commit 44a7eb8 https://app.netlify.com/sites/ro-reactjs/deploys/5e8ac88a7373a40007e9aba3 |
@nikiciv this might be ready for a re-review? |
@tesseralis @nikiciv - It would be great if we can merge this as I am waiting to continue work with the others. |
@gabrielmoncea you can start working on another page while this is in review! |
Hi, I would like to add some general rules to improve the translation to Romanian of the text in this commit (but these rules, I guess, could be used in the whole repo). First of all, I'm also a speaker of Russian and French, which are accepted already as finished translations, and based on my past experience in translating to Romanian, I recommend the following:
|
@micnic thanks a lot for the review. We were thinking on making a list of terminology that we should keep as it is in English. It would be great if you could jump in :D @tesseralis I will continue on this one to implement the review suggestions |
@gabrielmoncea will find some time, as I teach React, the documentation in Romanian would help students to understand it better in their native language. For now will follow the process of accepting of this PR. |
- id: external-resources | ||
title: External Resources | ||
title: Resurse Externe | ||
- title: Unelte |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S-ar putea ca sectiunea sa fie stearsa din master? @gabrielmoncea
title: Reguli ale Hook-urilor | ||
- id: hooks-custom | ||
title: Building Your Own Hooks | ||
title: Construieste-ti propriul Hook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aici am schimbat eu din Carlige in Hooks ca a fost conflict cu master-ul.. ma gandeam ca e putin mai ok. Ce parere aveti @gabrielmoncea @nikiciv ?
@gabrielmoncea minor comment la sectiunea 'Unelte', s-ar putea sa nu mai existe in master. Otherwise LGTM |
This PR adds Romanian translations to Home Page #7 , Header, Footer and Docs and Community Navs