Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation Forwarding refs #117

Merged
merged 14 commits into from
Feb 14, 2019
Merged

Translation Forwarding refs #117

merged 14 commits into from
Feb 14, 2019

Conversation

Heegiiny
Copy link
Collaborator

No description provided.

@Heegiiny Heegiiny added the needs review A pull request ready to be reviewed label Feb 13, 2019
@tesseralis tesseralis mentioned this pull request Feb 13, 2019
Closed
88 tasks
another-guy
another-guy requested changes Feb 13, 2019
View reviewed changes
content/docs/forwarding-refs.md Outdated Show resolved Hide resolved
content/docs/forwarding-refs.md Outdated Show resolved Hide resolved
content/docs/forwarding-refs.md Outdated Show resolved Hide resolved
content/docs/forwarding-refs.md Outdated Show resolved Hide resolved
content/docs/forwarding-refs.md Outdated Show resolved Hide resolved
content/docs/forwarding-refs.md Outdated Show resolved Hide resolved
content/docs/forwarding-refs.md Outdated Show resolved Hide resolved
content/docs/forwarding-refs.md Outdated Show resolved Hide resolved
content/docs/forwarding-refs.md Outdated Show resolved Hide resolved
content/docs/forwarding-refs.md Outdated Show resolved Hide resolved
angryermine
angryermine reviewed Feb 13, 2019
View reviewed changes
Copy link
Contributor

@angryermine angryermine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Привет, небольшая опечатка

examples/forwarding-refs/fancy-button-ref.js Outdated Show resolved Hide resolved
@Heegiiny Heegiiny added the work in progress Author opened the pull-request but it's still being worked on label Feb 13, 2019
lex111
lex111 reviewed Feb 13, 2019
View reviewed changes
content/docs/forwarding-refs.md Outdated Show resolved Hide resolved
content/docs/forwarding-refs.md Show resolved Hide resolved
content/docs/forwarding-refs.md Outdated Show resolved Hide resolved
content/docs/forwarding-refs.md Outdated Show resolved Hide resolved
@another-guy another-guy added needs proofread A read-through is still needed to release the document and removed needs review A pull request ready to be reviewed work in progress Author opened the pull-request but it's still being worked on labels Feb 14, 2019
another-guy
another-guy reviewed Feb 14, 2019
View reviewed changes
Copy link
Collaborator

@another-guy another-guy left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ещё несколько предложений после повторной вычитки целиком.

another-guy and others added 3 commits February 14, 2019 13:45
@another-guy @Heegiiny
Update content/docs/forwarding-refs.md
34a6dc1 
Co-Authored-By: Heegiiny <minatko@gmail.com>
@another-guy @Heegiiny
Update content/docs/forwarding-refs.md
a5324d0 
Co-Authored-By: Heegiiny <minatko@gmail.com>
@another-guy @Heegiiny
Update content/docs/forwarding-refs.md
4644352 
Co-Authored-By: Heegiiny <minatko@gmail.com>
another-guy and others added 2 commits February 14, 2019 13:46
@another-guy @Heegiiny
Update content/docs/forwarding-refs.md
cc51904 
Co-Authored-By: Heegiiny <minatko@gmail.com>
@another-guy @Heegiiny
Update examples/forwarding-refs/customized-display-name.js
7274209 
Co-Authored-By: Heegiiny <minatko@gmail.com>
@another-guy
Copy link
Collaborator

@lex111 я вЫчитал, как мог.

@lex111 lex111 merged commit bd10d98 into master Feb 14, 2019
@lex111
Copy link
Member

lex111 commented Feb 14, 2019

@Heegiiny всё хорошо, спасибо!

@Heegiiny Heegiiny deleted the forwarding-refs branch February 14, 2019 17:24
@lex111 lex111 mentioned this pull request Feb 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angryermine angryermine angryermine left review comments

@another-guy another-guy another-guy approved these changes

@lex111 lex111 lex111 approved these changes

Assignees
No one assigned
Labels
needs proofread A read-through is still needed to release the document
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Heegiiny @another-guy @lex111 @angryermine