Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate "Conditional Rendering" into Russian #60

Merged
merged 3 commits into from
Feb 11, 2019

Conversation

another-guy
Copy link
Collaborator

No description provided.

@another-guy another-guy added the needs review A pull request ready to be reviewed label Feb 10, 2019
@tesseralis tesseralis mentioned this pull request Feb 10, 2019
88 tasks
@another-guy another-guy force-pushed the another-guy/conditional-rendering branch from 1e38fb1 to e0ed28a Compare February 10, 2019 08:53
Copy link
Member

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нужно больше глаголов. Спасибо!

content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Show resolved Hide resolved
@gaearon gaearon added work in progress Author opened the pull-request but it's still being worked on and removed needs review A pull request ready to be reviewed labels Feb 10, 2019
@another-guy
Copy link
Collaborator Author

another-guy commented Feb 10, 2019

@gaearon поправки по твоим замечаниям внесены.

Я ознакомлен с рекоммендациями по переводу и теми рассказами про канцелярит, которыми ты поделился. Поверь, то, как написан перевод, уже опирается на советы. Просто даже во время самостоятельной вычитки перед PR эти "брёвна в своих глазах" практически не видны. Спасибо за терпение!

Учитывая, что твои замечания всегда по существу, немного расстраивает, что потрачено почти столько же твоего времени на ревью, сколько мог бы занять самостоятельный перевод.

P.S. Можно на "ты".

Copy link
Member

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мелочи остались, в целом хорошо. Ставлю апрув, но надо поправить перед мержем. Спасибо!

content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Outdated Show resolved Hide resolved
content/docs/conditional-rendering.md Show resolved Hide resolved
content/docs/conditional-rendering.md Show resolved Hide resolved
@another-guy another-guy removed the work in progress Author opened the pull-request but it's still being worked on label Feb 11, 2019
@another-guy another-guy merged commit 2e78ba6 into master Feb 11, 2019
@another-guy another-guy added the needs proofread A read-through is still needed to release the document label Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs proofread A read-through is still needed to release the document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants