Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(zh-hant): introducing jsx #13

Merged
merged 7 commits into from
Feb 20, 2019

Conversation

itszero
Copy link
Contributor

@itszero itszero commented Feb 15, 2019

This one is pretty hard because there're a lot of overloaded terms: React elements v.s. HTML elements etc. I try to stick to the glossary as to what to translate and what to keep in English.

Let me know if I missed anything or any feedbacks! 😄

Copy link
Member

@bugtender bugtender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍Looks great! Just add some suggestion. Please take a look.😳

content/docs/introducing-jsx.md Outdated Show resolved Hide resolved

Instead of artificially separating *technologies* by putting markup and logic in separate files, React [separates *concerns*](https://en.wikipedia.org/wiki/Separation_of_concerns) with loosely coupled units called "components" that contain both. We will come back to components in a [further section](/docs/components-and-props.html), but if you're not yet comfortable putting markup in JS, [this talk](https://www.youtube.com/watch?v=x7cQ3mrcKaY) might convince you otherwise.
與其刻意的將*技術*拆開,把標籤語法跟邏輯拆放於不同檔案之中,React [將*焦點*分散](https://en.wikipedia.org/wiki/Separation_of_concerns)的方法是將其拆分為很多同時包含 UI 與邏輯的 component,而彼此之間很少互相依賴。我們會在[之後的章節](/docs/components-and-props.html)中回來探討 component 這個主題,但如果你還沒被說服接受將標籤語法寫在 JS 裡頭,[這個演講](https://www.youtube.com/watch?v=x7cQ3mrcKaY)或許會說服你。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that should we keep the Italic style like 技術?

https://blog.justfont.com/2014/01/popular-typography-4/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we use bold instead? The default typography settings are also making it looks very bad on Linux, as in italic characters would clash into its neighbours.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separation of concerns usually be translated to 關注點分離. (can't get any relevant result when searching 焦點分散 on Google)

content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
Co-Authored-By: itszero <github@itsze.ro>
@chloewlin chloewlin added In Review Currently under review and removed Review Needed labels Feb 19, 2019
@chloewlin
Copy link
Member

@itszero I spotted three small things. Once they're fixed, I will merge this in asap.

@itszero
Copy link
Contributor Author

itszero commented Feb 20, 2019

Updated!

@netlify
Copy link

netlify bot commented Feb 20, 2019

Deploy preview for zh-hant-reactjs ready!

Built with commit fe89605

https://deploy-preview-13--zh-hant-reactjs.netlify.com

@itszero
Copy link
Contributor Author

itszero commented Feb 20, 2019

🤦‍♂️ tripple checked it is removed this time!

@chloewlin
Copy link
Member

Two small changes, then we're done! 💯

Co-Authored-By: itszero <github@itsze.ro>
@chloewlin chloewlin added Completed and removed In Review Currently under review labels Feb 20, 2019
@chloewlin chloewlin merged commit 9b8d414 into reactjs:master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants