Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New PR for form #59

Merged
merged 14 commits into from
Jun 27, 2019
Merged

New PR for form #59

merged 14 commits into from
Jun 27, 2019

Conversation

chloewlin
Copy link
Member

@chloewlin chloewlin commented May 25, 2019

This is a long overdue PR for the translation of form. I got stuck with some local conflicts because I did not check out from the master branch, so I decided to ditch that PR and start a new one. 🙈

This translation has been review previously in this PR here: #23

I believe that I've made all the changes, but please take a look and let me know if there is anything I should edit!

I will close the other PR once this is merged in!

@netlify
Copy link

netlify bot commented May 25, 2019

Deploy preview for zh-hant-reactjs-org ready!

Built with commit 006b646

https://deploy-preview-59--zh-hant-reactjs-org.netlify.com

content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
@neighborhood999 neighborhood999 added In Review Currently under review and removed Review Needed labels May 27, 2019
chloewlin and others added 10 commits June 23, 2019 18:33
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@chloewlin
Copy link
Member Author

@neighborhood999 Thanks for your great review! I accepted all the changes. Let me know if there are anything I still need to change. :)

Copy link
Member

@neighborhood999 neighborhood999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing MDN links to zh-TW

content/docs/forms.md Outdated Show resolved Hide resolved
Co-Authored-By: Peng Jie <dean.leehom@gmail.com>
@neighborhood999 neighborhood999 merged commit 6c8bf72 into reactjs:master Jun 27, 2019
@neighborhood999 neighborhood999 added Completed and removed In Review Currently under review labels Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants