Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the pom: no module metadata, fix name and description #181

Merged
merged 2 commits into from
Mar 29, 2021

Conversation

simonbasle
Copy link
Member

@simonbasle simonbasle commented Mar 25, 2021

Since the switch to more recent version of Gradle, two issues have been introduced in the pom:

  1. the name is wrong (doesn't pick up project.description from each submodule) - should be fixed by deferring the evaluation of project.description using afterEvaluate closure
  2. the junit-platform submodule publishes module file, while agent doesn't - for now we'll avoid generating the module metadata file by disabling the relevant tasks

@simonbasle simonbasle added the type/chore A task not related to code (build, formatting, process, ...) label Mar 25, 2021
@simonbasle simonbasle self-assigned this Mar 25, 2021
@simonbasle simonbasle requested a review from a team March 25, 2021 15:48
@simonbasle simonbasle changed the title Fix the pom: no module metadata, fix description Fix the pom: no module metadata, fix name and description Mar 25, 2021
@simonbasle
Copy link
Member Author

With @violetagg we've also noticed that the pom description is hardcoded and so isn't terribly relevant for the jblockhound-junit-platform submodule. I've used this PR as an opportunity to fix that.

cc @bsideup

@simonbasle simonbasle added this to the 1.0.5.RELEASE milestone Mar 25, 2021
@simonbasle simonbasle merged commit 7dd8d30 into master Mar 29, 2021
@simonbasle simonbasle deleted the fixPomGenerationNoModuleMetadata branch March 29, 2021 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore A task not related to code (build, formatting, process, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants