Ensure junit-platform has compile dep to blockhound in pom #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… blockhound in pom
bsideup
reviewed
Apr 1, 2021
junit-platform/build.gradle
Outdated
| @@ -1,5 +1,5 @@ | |||
| plugins { | |||
| id "java" | |||
| id "java-library" //historically publishes blockhound as compile dependency in pom | |||
There was a problem hiding this comment.
this sounds like something we're considering changing and is there only for legacy reasons, but (unless there are good reasons that should be discussed separately) this is not the case.
Suggested change
| id "java-library" //historically publishes blockhound as compile dependency in pom | |
| id "java-library" |
bsideup
reviewed
Apr 1, 2021
simonbasle
changed the title
|
will release tomorrow. please let me know if anything wrong other than the scope in pom is found in the current snapshot artifacts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @bsideup. If you could locally review and double check all seem in order in generated artifacts, that would be awesome.
if all is good, I'll release 1.0.6.RELEASE next Monday.