Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse compatibleVersion project property in benchmark build.gradle #330

Conversation

pderop
Copy link
Contributor

@pderop pderop commented Jan 26, 2023

When running the benchmark using the baseline (latest release of BlockHound) like this:

./gradlew --no-daemon benchmarks:jmh -PjmhTarget=baseline 

then the baseline version to use is hard coded in the benchmark build.gradle.
Now, for japicmp, we have introduced the baseline version in the gradle.properties (compatibleVersion).

Let's reuse this "compatibleVersion" project property from benchmark/gradle.properties, this will make a little bit easier the release process.

@pderop pderop self-assigned this Jan 26, 2023
@pderop pderop added the type/enhancement A general enhancement label Jan 26, 2023
@pderop pderop added this to the 1.0.7.RELEASE milestone Jan 26, 2023
@pderop
Copy link
Contributor Author

pderop commented Jan 26, 2023

Since this PR is trivial, I'm going to merge it without any code review.

@pderop pderop merged commit 5e1216c into reactor:master Jan 26, 2023
@pderop pderop added type/chore A task not related to code (build, formatting, process, ...) and removed type/enhancement A general enhancement labels Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore A task not related to code (build, formatting, process, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant