Shading is the gift that keeps on giving #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbasle
approved these changes
Oct 21, 2019
bsideup
commented
Oct 21, 2019
bsideup
commented
Oct 22, 2019
| exclude 'META-INF/maven/**' | ||
| exclude 'reactor/shaded/META-INF/**' | ||
|
|
||
| // TODO discuss with ByteBuddy folks how to shade it |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in netty/netty#9687, due to GradleUp/shadow#519, we have
reactor/shaded/META-INF/versions/9/module-info.classfile in the final JAR, although we thought that we excluded it.This PR fixes a few related shading issues and adds the missing tests for the shadowed jar, so that we will never miss such issue again.