sendFile marks the response as compressed but does not compress the body

[bclozel]

This is a follow up issue for #340, the issue is only present on 0.7.x (it's apparently already fixed in the 0.8.x branch).

When writing static resources using sendFile and using an HTTP compression predicate, the HTTP response contains the gzip encoding header, but the actual response body is not compressed as it should be.

Steps to reproduce

The sample application listed here shows the problem.

It seems that the predicate is called twice: once during the sendFile call, and another time when flushing the HTTP headers. As mentioned here, it seems that 0.8.x removed the compression check in HttpServerOperations and everything works as expected.

[violetagg]

I added test cases to cover this issue bcde045. I do not see an issue in Reactor Netty for the moment.
I suspect an issue in Spring Framework https://jira.spring.io/browse/SPR-17348.
Closing, you can reopen it later if it appears Reactor Netty issue.

[violetagg]

It is an issue in Reactor Netty - the decision for DefaultFileRegion vs ChunkedInput should be deferred.

[violetagg]

Fixed with #451