Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unused methods #2209

Merged
merged 1 commit into from
May 18, 2022
Merged

Removed unused methods #2209

merged 1 commit into from
May 18, 2022

Conversation

violetagg
Copy link
Member

Related to PR #2203

@violetagg violetagg added the type/enhancement A general enhancement label May 18, 2022
@violetagg violetagg added this to the 2.0.0-M1 milestone May 18, 2022
@violetagg violetagg requested a review from a team May 18, 2022 11:51
pderop
pderop approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@violetagg
Copy link
Member Author

@pderop @simonbasle Thanks for the review!

@violetagg violetagg merged commit 9f98b1e into netty5 May 18, 2022
@violetagg violetagg deleted the unused-method branch May 18, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbasle simonbasle simonbasle approved these changes

@pderop pderop pderop approved these changes

Assignees
No one assigned
Labels
type/enhancement A general enhancement
Projects
None yet
Milestone
2.0.0-M1
Development

Successfully merging this pull request may close these issues.
3 participants
@violetagg @pderop @simonbasle