Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate NettyPipeline#UnvoidHandler #2248

Merged
merged 1 commit into from
May 25, 2022
Merged

Deprecate NettyPipeline#UnvoidHandler #2248

merged 1 commit into from
May 25, 2022

Conversation

violetagg
Copy link
Member

Netty 5 does not support VoidChannelPromise

@violetagg
Deprecate NettyPipeline#UnvoidHandler
817a65c 
Netty 5 does not support VoidChannelPromise
@violetagg violetagg added the warn/deprecation This issue/PR introduces deprecations label May 25, 2022
@violetagg violetagg added this to the 1.1.0-M3 milestone May 25, 2022
@violetagg violetagg requested a review from a team May 25, 2022 10:44
pderop
pderop approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@violetagg
Copy link
Member Author

@pderop Thanks for the review!

@violetagg violetagg merged commit 9317f1f into main May 25, 2022
@violetagg violetagg deleted the deprecate-unvoid-handler branch May 25, 2022 11:30
violetagg added a commit that referenced this pull request May 25, 2022
@violetagg
Merge #2248 into netty5
acbcab5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pderop pderop pderop approved these changes

Assignees
No one assigned
Labels
warn/deprecation This issue/PR introduces deprecations
Projects
None yet
Milestone
1.1.0-M3
Development

Successfully merging this pull request may close these issues.
2 participants
@violetagg @pderop