Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to the new ChannelFactory/ServerChannelFactory #2272

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

violetagg
Copy link
Member

In Netty 5 we have now

/**
 * Creates a new {@link Channel}.
 */
public interface ChannelFactory<T extends Channel> {
    /**
     * Creates a new channel.
     */
    T newChannel(EventLoop eventLoop) throws Exception;
}
/**
 * Creates a new {@link ServerChannel}.
 */
public interface ServerChannelFactory<T extends ServerChannel> {
    /**
     * Creates a new channel.
     */
    T newChannel(EventLoop eventLoop, EventLoopGroup childEventLoopGroup) throws Exception;
}

Related to #1873

@violetagg violetagg added the type/enhancement A general enhancement label Jun 9, 2022
@violetagg violetagg added this to the 2.0.0-M1 milestone Jun 9, 2022
@violetagg violetagg requested a review from a team June 9, 2022 15:17
Copy link
Contributor

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@violetagg
Copy link
Member Author

@pderop Thanks for the review

@violetagg violetagg merged commit 06a0194 into netty5 Jun 10, 2022
@violetagg violetagg deleted the channelfactory-serverchannelfactory branch June 10, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants