Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate NettyInbound/NettyOutbound to Buffer #2299

Merged
merged 6 commits into from
Jun 16, 2022
Merged

Migrate NettyInbound/NettyOutbound to Buffer #2299

merged 6 commits into from
Jun 16, 2022

Conversation

violetagg
Copy link
Member

Related to #1873

@violetagg violetagg added the type/enhancement A general enhancement label Jun 15, 2022
@violetagg violetagg added this to the 2.0.0-M1 milestone Jun 15, 2022
@violetagg violetagg requested a review from a team June 15, 2022 12:04
pderop
pderop reviewed Jun 15, 2022
View reviewed changes
Copy link
Contributor

@pderop pderop left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check copyright year of the following modified files:

reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client/send/Application.java
reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client/warmup/Application.java
reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/server/routing/Application.java
reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/server/sse/Application.java

reactor-netty-core/src/main/java/reactor/netty/channel/ChannelOperationsHandler.java Show resolved Hide resolved
@violetagg
Copy link
Member Author

Please check copyright year of the following modified files:

reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client/send/Application.java reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/client/warmup/Application.java reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/server/routing/Application.java reactor-netty-examples/src/main/java/reactor/netty/examples/documentation/http/server/sse/Application.java

fixed

pderop
pderop approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@violetagg
Copy link
Member Author

@pderop @simonbasle Thanks

@violetagg violetagg merged commit f93f5a1 into netty5 Jun 16, 2022
@violetagg violetagg deleted the migrate-to-buffer-api branch June 16, 2022 13:39
violetagg added a commit that referenced this pull request Jun 27, 2022
@violetagg
Ensure BufferMono is used when full request is needed
7873d9f 
This was wrong migration see #2299
`ByteBufMono -> BufferFlux`

Related to #1873
@violetagg violetagg mentioned this pull request Jun 27, 2022
Merged
violetagg added a commit that referenced this pull request Jun 27, 2022
@violetagg
Ensure BufferMono is used when full request is needed (#2333)
b1dfc8a 
This was wrong migration see #2299
`ByteBufMono -> BufferFlux`

Related to #1873
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbasle simonbasle simonbasle approved these changes

@pderop pderop pderop approved these changes

Assignees
No one assigned
Labels
type/enhancement A general enhancement
Projects
None yet
Milestone
2.0.0-M1
Development

Successfully merging this pull request may close these issues.
3 participants
@violetagg @pderop @simonbasle