Do not open a stream on a connection that received GOAWAY #2408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the specification https://www.rfc-editor.org/rfc/rfc9113.html#section-6.8 `Receivers of a GOAWAY frame MUST NOT open additional streams on the connection` Reactor Netty by default is running with graceful shutdown which means that `GOAWAY` might be received and the connection to be still alive. `Http2Pool` should consider this use case and stop offering a connection that received `GOAWAY`. Fixes #2396
|
@simonbasle Thanks for the review! |
violetagg
added a commit
that referenced
this pull request
Jul 28, 2022
violetagg
added a commit
that referenced
this pull request
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the specification
https://www.rfc-editor.org/rfc/rfc9113.html#section-6.8
Receivers of a GOAWAY frame MUST NOT open additional streams on the connectionReactor Netty by default is running with graceful shutdown which means that
GOAWAYmight be received and the connection to be still alive.
Http2Poolshould consider this use case and stop offering a connection that receivedGOAWAY.Fixes #2396