Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IllegalArgumentException: Channel [...] was not acquired from this ChannelPool #266

Merged
merged 1 commit into from
Jan 31, 2018

Conversation

violetagg
Copy link
Member

No description provided.

@violetagg violetagg added this to the 0.7.4.RELEASE milestone Jan 30, 2018
@codecov-io
Copy link

codecov-io commented Jan 30, 2018

Codecov Report

Merging #266 into master will increase coverage by 0.11%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #266      +/-   ##
===========================================
+ Coverage     67.28%   67.4%   +0.11%     
- Complexity      997    1002       +5     
===========================================
  Files            73      73              
  Lines          4255    4255              
  Branches        603     603              
===========================================
+ Hits           2863    2868       +5     
+ Misses         1029    1023       -6     
- Partials        363     364       +1
Impacted Files Coverage Δ Complexity Δ
.../ipc/netty/channel/PooledClientContextHandler.java 58.53% <66.66%> (-0.82%) 24 <2> (ø)
...in/java/reactor/ipc/netty/channel/FluxReceive.java 81.12% <0%> (-1.54%) 61% <0%> (-1%)
...java/reactor/ipc/netty/channel/ContextHandler.java 73.52% <0%> (+1.96%) 27% <0%> (+1%) ⬆️
...tor/ipc/netty/channel/CloseableContextHandler.java 57.89% <0%> (+5.26%) 9% <0%> (+1%) ⬆️
...ctor/ipc/netty/http/server/CompressionHandler.java 82.14% <0%> (+7.14%) 20% <0%> (+2%) ⬆️
...va/reactor/ipc/netty/channel/AbortedException.java 54.54% <0%> (+9.09%) 7% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 212593c...c453223. Read the comment docs.

smaldini pushed a commit that referenced this pull request Jan 30, 2018
Disable pooling for now
Remove event type from ConnectionEvents
Fix some tests
Include fix #266 and 267
@smaldini
Copy link
Contributor

Might want to add extra log for failure in debug mode.

@violetagg
Copy link
Member Author

Might want to add extra log for failure in debug mode.

done

@violetagg violetagg merged commit c453223 into master Jan 31, 2018
@violetagg violetagg deleted the channel-was-not-acquired branch January 31, 2018 11:12
violetagg pushed a commit that referenced this pull request May 16, 2018
Disable pooling for now
Remove event type from ConnectionEvents
Fix some tests
Include fix #266 and 267
violetagg pushed a commit that referenced this pull request May 28, 2018
Disable pooling for now
Remove event type from ConnectionEvents
Fix some tests
Include fix #266 and 267
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants