Add Reactor Netty version of secure chat server example reactor#761 #2677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchenga
force-pushed
the
761-secure-chat-server
branch
2 times, most recently
from
a18e566
to
e3760b6
Compare
|
I am not sure why build (windows-2019, nio) failed. the check failed with assertion exception at ITTracingHttpClientDecoratorTest, but the same test succeeded with other OS platforms. |
pderop
requested changes
Feb 1, 2023
...tor-netty-examples/src/main/java/reactor/netty/examples/tcp/securechat/SecureChatClient.java
Outdated
Show resolved
Hide resolved
...tor-netty-examples/src/main/java/reactor/netty/examples/tcp/securechat/SecureChatServer.java
Outdated
Show resolved
Hide resolved
violetagg
added
type/documentation
pderop
reviewed
Feb 1, 2023
...tor-netty-examples/src/main/java/reactor/netty/examples/tcp/securechat/SecureChatServer.java
Show resolved
Hide resolved
jchenga
force-pushed
the
761-secure-chat-server
branch
from
e3760b6
to
1a02a75
Compare
violetagg
reviewed
Feb 6, 2023
...tor-netty-examples/src/main/java/reactor/netty/examples/tcp/securechat/SecureChatClient.java
Outdated
Show resolved
Hide resolved
Provide a corresponding Reactor Netty version of Secure chat server example as found in Netty project.
jchenga
force-pushed
the
761-secure-chat-server
branch
from
1a02a75
to
c807f5d
Compare
violetagg
approved these changes
Feb 7, 2023
pderop
added a commit
that referenced
this pull request
Feb 7, 2023
|
@jchenga , thanks for the PR; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a corresponding Reactor Netty version of Secure chat server example as found in Netty project.
Related to #761