Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpServer: Add API for read related timeouts #2836

Merged
merged 9 commits into from
Jun 20, 2023
Merged

HttpServer: Add API for read related timeouts #2836

merged 9 commits into from
Jun 20, 2023

Conversation

violetagg
Copy link
Member

Fixes #2770

@violetagg violetagg added the type/enhancement A general enhancement label Jun 19, 2023
@violetagg violetagg added this to the 1.1.9 milestone Jun 19, 2023
@violetagg violetagg requested a review from a team June 19, 2023 06:36
@violetagg violetagg mentioned this pull request Jun 19, 2023
Closed
@violetagg
Copy link
Member Author

The failed tests seem to be a timing issue. Checking ...

@violetagg
Copy link
Member Author

The test should be fixed now

philsttr
philsttr reviewed Jun 20, 2023
View reviewed changes
Copy link
Contributor

@philsttr philsttr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM! Just had one minor doc comment. Thank you. :)

reactor-netty-http/src/main/java/reactor/netty/http/server/HttpServer.java Outdated Show resolved Hide resolved
pderop
pderop approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@pderop pderop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good !

@violetagg violetagg merged commit 70f5161 into main Jun 20, 2023
9 checks passed
@violetagg violetagg deleted the http-server-request-timeout branch June 20, 2023 17:13
violetagg added a commit that referenced this pull request Jun 20, 2023
@violetagg
Merge #2836 into 2.0.0-M4
7397fe5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philsttr philsttr philsttr left review comments

@pderop pderop pderop approved these changes

Assignees
No one assigned
Labels
type/enhancement A general enhancement
Projects
None yet
Milestone
1.1.9
Development

Successfully merging this pull request may close these issues.

HttpServer read related timeouts
3 participants
@violetagg @pderop @philsttr