Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #309 In case there is a failure while decoding the request, return 4xx response #310

Merged
merged 1 commit into from
Mar 23, 2018

Conversation

violetagg
Copy link
Member

When the decoding failed with TooLongFrameException, 413 Request Entity Too Large will be returned otherwise 400 Bad Request

@violetagg violetagg requested a review from smaldini March 21, 2018 16:38
@violetagg violetagg added this to the 0.7.6.RELEASE milestone Mar 21, 2018
@codecov-io
Copy link

codecov-io commented Mar 21, 2018

Codecov Report

Merging #310 into master will decrease coverage by 0.29%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master    #310     +/-   ##
==========================================
- Coverage     68.49%   68.2%   -0.3%     
+ Complexity     1025    1021      -4     
==========================================
  Files            73      73             
  Lines          4295    4306     +11     
  Branches        616     618      +2     
==========================================
- Hits           2942    2937      -5     
- Misses          981     996     +15     
- Partials        372     373      +1
Impacted Files Coverage Δ Complexity Δ
...actor/ipc/netty/http/server/HttpServerHandler.java 79.02% <90.9%> (+0.99%) 42 <0> (+1) ⬆️
...tor/ipc/netty/channel/CloseableContextHandler.java 52.63% <0%> (-5.27%) 8% <0%> (-1%)
.../ipc/netty/http/client/MonoHttpClientResponse.java 77.02% <0%> (-4.06%) 6% <0%> (ø)
...or/ipc/netty/http/client/HttpClientOperations.java 56.31% <0%> (-2.64%) 78% <0%> (-4%)
...a/reactor/ipc/netty/channel/ChannelOperations.java 81.95% <0%> (-1.51%) 47% <0%> (-1%)
src/main/java/reactor/ipc/netty/FutureMono.java 86% <0%> (+4%) 6% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f442243...9de45ae. Read the comment docs.

…n 4xx response

When the decoding failed with "TooLongFrameException", "413 Request
Entity Too Large" will be returned otherwise "400 Bad Request"
@violetagg violetagg merged commit 9de45ae into master Mar 23, 2018
@violetagg violetagg deleted the issue-309 branch March 27, 2018 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants