Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re enable full build with jdk17 #3138

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Conversation

pderop
Copy link
Contributor

@pderop pderop commented Apr 4, 2024

Since the migration to Antora, it's not possible anymore to do a full build using jdk17:

sdk use java 17.0.10-zulu
./gradlew publishToMavenLocal

> Configure project :
1.2.0-SNAPSHOT is a snapshot, will use 1.2.0.BUILD-202404040843 for bnd
[Spotless] Local run detected, ratchet from origin/main

> Task :docs:generatePomFileForMavenJavaPublication FAILED

FAILURE: Build failed with an exception.

* Where:
Script '/Users/***/Documents/reactor-netty/gradle/setup.gradle' line: 153

* What went wrong:
Execution failed for task ':docs:generatePomFileForMavenJavaPublication'.
> Could not apply withXml() to generated POM
   > Cannot invoke method children() on null object

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org/

This PR re enable full build using jdk17:

  • in build.gradle: toolchain sets JDK17 for docs sub project
  • in gradle/settings.gradle, the docs project must be excluded, it does not contain dependencies, that was causing the Cannot invoke method children() on null object error
  • in reactor-netty/build.gradle: if JDK17 is used, then a dependency to `:docs:antora' is dynamically added for the docsZip task.

@pderop pderop added the type/chore A task not related to code (build, formatting, process, ...) label Apr 4, 2024
@pderop pderop added this to the 1.2.0-M1 milestone Apr 4, 2024
@pderop pderop self-assigned this Apr 4, 2024
@pderop pderop requested a review from violetagg April 4, 2024 10:18
@violetagg violetagg modified the milestones: 1.2.0-M1, 1.2.0-M2 Apr 5, 2024
@pderop pderop force-pushed the re-enable-full-build-with-jdk17 branch from 5100780 to dae2b9c Compare April 16, 2024 12:38
@pderop
Copy link
Contributor Author

pderop commented Apr 16, 2024

Rebased on top of latest main branch in order to manually merge #3140 which was conflicting with this PR.

@pderop
Copy link
Contributor Author

pderop commented Apr 16, 2024

@violetagg , thanks for your review!

@pderop pderop merged commit b7f9bbb into main Apr 16, 2024
15 checks passed
@pderop pderop deleted the re-enable-full-build-with-jdk17 branch April 16, 2024 13:09
pderop added a commit that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore A task not related to code (build, formatting, process, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants