Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't share pipeline state in fields of the FileChunkedStrategy instance #319

Merged
merged 2 commits into from
Apr 11, 2018

Conversation

lhotari
Copy link
Contributor

@lhotari lhotari commented Apr 11, 2018

  • replace shared state with check each time
  • remove redundant check in NettyOutbound.sendFileChunked

@codecov-io
Copy link

Codecov Report

Merging #319 into master will increase coverage by 0.05%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #319      +/-   ##
============================================
+ Coverage     68.22%   68.28%   +0.05%     
- Complexity     1020     1022       +2     
============================================
  Files            73       73              
  Lines          4312     4310       -2     
  Branches        618      615       -3     
============================================
+ Hits           2942     2943       +1     
- Misses          997      998       +1     
+ Partials        373      369       -4
Impacted Files Coverage Δ Complexity Δ
src/main/java/reactor/ipc/netty/NettyOutbound.java 84.74% <100%> (+2.77%) 27 <0> (ø) ⬇️
...etty/channel/data/AbstractFileChunkedStrategy.java 69.56% <60%> (+4.34%) 6 <4> (+2) ⬆️
.../ipc/netty/channel/PooledClientContextHandler.java 67.22% <0%> (-0.85%) 26% <0%> (-1%)
...or/ipc/netty/http/server/HttpServerOperations.java 71.05% <0%> (+0.52%) 56% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b35f95...5b52439. Read the comment docs.

@violetagg violetagg added the type/bug A general bug label Apr 11, 2018
@violetagg violetagg added this to the 0.7.7.RELEASE milestone Apr 11, 2018
@violetagg violetagg merged commit 17923ff into reactor:master Apr 11, 2018
@violetagg
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants