Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #316 Correctly calculate the requested and produced items #327

Merged
merged 1 commit into from
Apr 19, 2018
Merged

fix #316 Correctly calculate the requested and produced items #327

merged 1 commit into from
Apr 19, 2018

Conversation

violetagg
Copy link
Member

Take in account the delayed writes when calculating the requested
and produced items when onComplete/onError event is sent.

@codecov-io
Copy link

codecov-io commented Apr 19, 2018

Codecov Report

Merging #327 into master will decrease coverage by 0.24%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #327      +/-   ##
============================================
- Coverage     68.37%   68.12%   -0.25%     
+ Complexity     1025     1020       -5     
============================================
  Files            73       73              
  Lines          4310     4314       +4     
  Branches        615      614       -1     
============================================
- Hits           2947     2939       -8     
- Misses          994     1005      +11     
- Partials        369      370       +1
Impacted Files Coverage Δ Complexity Δ
...or/ipc/netty/channel/ChannelOperationsHandler.java 63.97% <75%> (-0.14%) 59 <1> (-1)
...tor/ipc/netty/channel/CloseableContextHandler.java 52.63% <0%> (-5.27%) 8% <0%> (-1%)
...or/ipc/netty/http/client/HttpClientOperations.java 56.31% <0%> (-1.58%) 78% <0%> (-2%)
...a/reactor/ipc/netty/channel/ChannelOperations.java 82.48% <0%> (-1.46%) 47% <0%> (-1%)
...or/ipc/netty/http/server/HttpServerOperations.java 70.52% <0%> (-0.53%) 55% <0%> (-1%)
...va/reactor/ipc/netty/channel/AbortedException.java 54.54% <0%> (+9.09%) 6% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e91086...c9b0f05. Read the comment docs.

Take in account the delayed writes when calculating the requested
and produced items when onComplete/onError event is sent.
@violetagg violetagg merged commit c9b0f05 into reactor:master Apr 19, 2018
@violetagg violetagg deleted the issue-316 branch April 19, 2018 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants