Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #340 When compression is enabled do not send file with zero copy #341

Merged
merged 1 commit into from
Apr 27, 2018
Merged

fix #340 When compression is enabled do not send file with zero copy #341

merged 1 commit into from
Apr 27, 2018

Conversation

violetagg
Copy link
Member

When compression is enabled do not send file with zero copy instead
use chunking

When compression is enabled do not send file with zero copy instead
use chunking
@violetagg violetagg requested a review from smaldini April 27, 2018 16:01
@violetagg violetagg added this to the 0.7.7.RELEASE milestone Apr 27, 2018
@codecov-io
Copy link

codecov-io commented Apr 27, 2018

Codecov Report

Merging #341 into master will increase coverage by 0.37%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #341      +/-   ##
============================================
+ Coverage     68.99%   69.36%   +0.37%     
- Complexity     1043     1048       +5     
============================================
  Files            72       72              
  Lines          4383     4384       +1     
  Branches        625      626       +1     
============================================
+ Hits           3024     3041      +17     
+ Misses          980      967      -13     
+ Partials        379      376       -3
Impacted Files Coverage Δ Complexity Δ
src/main/java/reactor/ipc/netty/NettyOutbound.java 83.33% <100%> (+0.28%) 28 <0> (+1) ⬆️
...or/ipc/netty/channel/ChannelOperationsHandler.java 67.03% <0%> (+0.44%) 59% <0%> (ø) ⬇️
...or/ipc/netty/http/server/HttpServerOperations.java 70.89% <0%> (+1.58%) 56% <0%> (+1%) ⬆️
...a/reactor/ipc/netty/channel/ChannelOperations.java 82.81% <0%> (+2.34%) 46% <0%> (+1%) ⬆️
...ctor/ipc/netty/resources/DefaultPoolResources.java 79.31% <0%> (+3.44%) 9% <0%> (+1%) ⬆️
.../ipc/netty/channel/PooledClientContextHandler.java 63.02% <0%> (+4.2%) 25% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23bd118...ac103c0. Read the comment docs.

@violetagg violetagg merged commit ac103c0 into reactor:master Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants