Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved ws condition support #354

Merged
merged 1 commit into from
May 14, 2018
Merged

Improved ws condition support #354

merged 1 commit into from
May 14, 2018

Conversation

segabriel
Copy link
Contributor

It would be great to have a more general predicate.

@pivotal-issuemaster
Copy link

@segabriel Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@segabriel Thank you for signing the Contributor License Agreement!

@codecov-io
Copy link

Codecov Report

Merging #354 into master will increase coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #354      +/-   ##
============================================
+ Coverage     69.21%   69.27%   +0.05%     
- Complexity     1048     1049       +1     
============================================
  Files            72       72              
  Lines          4402     4403       +1     
  Branches        630      630              
============================================
+ Hits           3047     3050       +3     
- Misses          973      975       +2     
+ Partials        382      378       -4
Impacted Files Coverage Δ Complexity Δ
...eactor/ipc/netty/http/server/HttpServerRoutes.java 18.18% <0%> (-0.57%) 6 <0> (ø)
...tor/ipc/netty/channel/CloseableContextHandler.java 52.63% <0%> (-5.27%) 8% <0%> (-1%)
.../ipc/netty/channel/PooledClientContextHandler.java 63.02% <0%> (-0.85%) 25% <0%> (-1%)
...or/ipc/netty/channel/ChannelOperationsHandler.java 67.7% <0%> (+0.44%) 61% <0%> (+1%) ⬆️
...in/java/reactor/ipc/netty/channel/FluxReceive.java 83.67% <0%> (+0.51%) 67% <0%> (+1%) ⬆️
src/main/java/reactor/ipc/netty/FutureMono.java 69.16% <0%> (+1.66%) 8% <0%> (ø) ⬇️
.../ipc/netty/http/server/HttpServerWSOperations.java 63.15% <0%> (+1.75%) 14% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da0c082...4586148. Read the comment docs.

@violetagg violetagg merged commit 7dc9f30 into reactor:master May 14, 2018
@violetagg
Copy link
Member

Thanks

@violetagg violetagg added this to the 0.7.8.RELEASE milestone May 14, 2018
@violetagg violetagg added the type/enhancement A general enhancement label May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants