Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #301 Add Http Server Access Log #428

Merged
merged 1 commit into from
Sep 4, 2018
Merged

fix #301 Add Http Server Access Log #428

merged 1 commit into from
Sep 4, 2018

Conversation

violetagg
Copy link
Member

Only CLF is supported
-Dreactor.netty.http.server.accessLogEnabled=true can be used to enable access log (by default it is disabled)
The configuration below (logback) or similar (other logging frameworks) can be used to have a separate access log file

    <appender name="accessLog" class="ch.qos.logback.core.FileAppender">
        <file>access_log.log</file>
        <encoder>
            <pattern>%msg%n</pattern>
        </encoder>
    </appender>
    <appender name="async" class="ch.qos.logback.classic.AsyncAppender">
        <appender-ref ref="accessLog" />
    </appender>

    <logger name="reactor.netty.http.server.AccessLog" level="INFO" additivity="false">
        <appender-ref ref="async"/>
    </logger>

@codecov-io
Copy link

codecov-io commented Sep 4, 2018

Codecov Report

Merging #428 into 0.7.x will decrease coverage by 0.72%.
The diff coverage is 13.15%.

Impacted file tree graph

@@             Coverage Diff              @@
##              0.7.x     #428      +/-   ##
============================================
- Coverage     68.86%   68.13%   -0.73%     
- Complexity     1050     1054       +4     
============================================
  Files            72       73       +1     
  Lines          4439     4507      +68     
  Branches        644      653       +9     
============================================
+ Hits           3057     3071      +14     
- Misses          991     1044      +53     
- Partials        391      392       +1
Impacted Files Coverage Δ Complexity Δ
src/main/java/reactor/ipc/netty/NettyPipeline.java 100% <ø> (ø) 3 <0> (ø) ⬇️
...eactor/ipc/netty/http/server/AccessLogHandler.java 0% <0%> (ø) 0 <0> (?)
...java/reactor/ipc/netty/http/server/HttpServer.java 88.42% <83.33%> (-1.69%) 20 <0> (ø)
...or/ipc/netty/http/server/HttpServerOperations.java 68.75% <0%> (+0.52%) 58% <0%> (+1%) ⬆️
.../ipc/netty/channel/PooledClientContextHandler.java 68.06% <0%> (+9.24%) 27% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f778f53...e26831e. Read the comment docs.

@violetagg violetagg added this to the 0.7.9.RELEASE milestone Sep 4, 2018
@violetagg violetagg merged commit e26831e into 0.7.x Sep 4, 2018
@smaldini smaldini deleted the issue-301 branch September 19, 2018 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants