Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not close the channel directly but mark it for closing #446

Closed
wants to merge 1 commit into from

Conversation

violetagg
Copy link
Member

The channel will be closed while releasing it.
The original exception that is received is Connection reset by peer,
but as a result of a direct close invocation, SSLEngine closed already
is forwarded to the user:

    at reactor.ipc.netty.http.client.HttpClientOperations.onOutboundError(HttpClientOperations.java:530)
    at reactor.ipc.netty.channel.ChannelOperations.onError(ChannelOperations.java:234)
    at reactor.core.publisher.Operators$MonoSubscriber.onError(Operators.java:1126)
    at reactor.core.publisher.MonoIgnoreThen$ThenIgnoreInner.onError(MonoIgnoreThen.java:234)
    at reactor.ipc.netty.FutureMono$FutureSubscription.operationComplete(FutureMono.java:298)
    ...
    at io.netty.handler.ssl.SslHandler.wrap(SslHandler.java:830)
    at io.netty.handler.ssl.SslHandler.wrapAndFlush(SslHandler.java:793)
    at io.netty.handler.ssl.SslHandler.flush(SslHandler.java:774)
    at io.netty.handler.ssl.SslHandler.flush(SslHandler.java:1647)
    at io.netty.handler.ssl.SslHandler.closeOutboundAndChannel(SslHandler.java:1615)
    at io.netty.handler.ssl.SslHandler.close(SslHandler.java:732)
    ...
    at io.netty.channel.AbstractChannel.close(AbstractChannel.java:238)
    at reactor.ipc.netty.channel.FluxReceive.onInboundError(FluxReceive.java:359)
    at reactor.ipc.netty.channel.ChannelOperations.onInboundError(ChannelOperations.java:429)
    at reactor.ipc.netty.channel.ChannelOperationsHandler.exceptionCaught(ChannelOperationsHandler.java:182)
    at io.netty.channel.AbstractChannelHandlerContext.invokeExceptionCaught(AbstractChannelHandlerContext.java:285)
    ...

@codecov-io
Copy link

codecov-io commented Oct 2, 2018

Codecov Report

Merging #446 into 0.7.x will increase coverage by 0.39%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             0.7.x    #446      +/-   ##
==========================================
+ Coverage     68.1%   68.5%   +0.39%     
- Complexity    1054    1060       +6     
==========================================
  Files           73      73              
  Lines         4512    4512              
  Branches       653     653              
==========================================
+ Hits          3073    3091      +18     
+ Misses        1048    1032      -16     
+ Partials       391     389       -2
Impacted Files Coverage Δ Complexity Δ
...in/java/reactor/ipc/netty/channel/FluxReceive.java 83.16% <100%> (ø) 66 <0> (ø) ⬇️
...or/ipc/netty/channel/ChannelOperationsHandler.java 65.93% <0%> (+1.09%) 61% <0%> (+1%) ⬆️
...java/reactor/ipc/netty/channel/ContextHandler.java 76.69% <0%> (+1.94%) 28% <0%> (+1%) ⬆️
...ctor/ipc/netty/resources/DefaultPoolResources.java 79.38% <0%> (+3.09%) 9% <0%> (+1%) ⬆️
.../ipc/netty/channel/PooledClientContextHandler.java 71.42% <0%> (+4.2%) 28% <0%> (+1%) ⬆️
...va/reactor/ipc/netty/channel/AbortedException.java 63.63% <0%> (+27.27%) 6% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8db29c...d56ca0a. Read the comment docs.

The channel will be closed while releasing it.
The original exception that is received is `Connection reset by peer`,
but as a result of a direct close invocation, `SSLEngine closed already`
is forwarded to the user:

    ```
    at reactor.ipc.netty.http.client.HttpClientOperations.onOutboundError(HttpClientOperations.java:530)
    at reactor.ipc.netty.channel.ChannelOperations.onError(ChannelOperations.java:234)
    at reactor.core.publisher.Operators$MonoSubscriber.onError(Operators.java:1126)
    at reactor.core.publisher.MonoIgnoreThen$ThenIgnoreInner.onError(MonoIgnoreThen.java:234)
    at reactor.ipc.netty.FutureMono$FutureSubscription.operationComplete(FutureMono.java:298)
    ...
    at io.netty.handler.ssl.SslHandler.wrap(SslHandler.java:830)
    at io.netty.handler.ssl.SslHandler.wrapAndFlush(SslHandler.java:793)
    at io.netty.handler.ssl.SslHandler.flush(SslHandler.java:774)
    at io.netty.handler.ssl.SslHandler.flush(SslHandler.java:1647)
    at io.netty.handler.ssl.SslHandler.closeOutboundAndChannel(SslHandler.java:1615)
    at io.netty.handler.ssl.SslHandler.close(SslHandler.java:732)
    ...
    at io.netty.channel.AbstractChannel.close(AbstractChannel.java:238)
    at reactor.ipc.netty.channel.FluxReceive.onInboundError(FluxReceive.java:359)
    at reactor.ipc.netty.channel.ChannelOperations.onInboundError(ChannelOperations.java:429)
    at reactor.ipc.netty.channel.ChannelOperationsHandler.exceptionCaught(ChannelOperationsHandler.java:182)
    at io.netty.channel.AbstractChannelHandlerContext.invokeExceptionCaught(AbstractChannelHandlerContext.java:285)
    ...
    ```
@violetagg
Copy link
Member Author

Fixed with 3941fcd

@violetagg violetagg closed this Oct 3, 2018
@violetagg violetagg deleted the issue-413 branch October 3, 2018 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants