Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Gradle 6.5.1 and add japicmp #96

Closed
12 of 13 tasks
simonbasle opened this issue Aug 10, 2020 · 0 comments
Closed
12 of 13 tasks

Bump to Gradle 6.5.1 and add japicmp #96

simonbasle opened this issue Aug 10, 2020 · 0 comments
Assignees
Labels
type/chore A task not related to code (build, formatting, process, ...)
Milestone

Comments

@simonbasle
Copy link
Member

simonbasle commented Aug 10, 2020

  • Bump to Gradle 6.5.1

    • remove OsgiHelper import and usage
    • bump artifactory to 4.15.2
    • add bnd plugin id 'biz.aQute.bnd.builder' version '5.0.1' apply false
    • avoid generating module metadata (see snippet below)
    • apply plugin: 'biz.aQute.bnd.builder'
    • replace bundleImportPackages with a bndOptions string[][] array (see below)
    • configure bnd with the bndOptions in the jar task: bnd(bndOptions)
  • add plugin id "me.champeau.gradle.japicmp" version "0.2.6"

    • add plugin id "de.undercouch.download" version "3.4.3"
    • check.dependsOn japicmp
    • add downloadBaseline and japicmp tasks (without the Rule, only simplified exclusions)
    • add compatibleVersion=0.1.0.RELEASE to gradle.properties

To avoid generating module metadata:

tasks.withType(GenerateModuleMetadata) {
  enabled = false
}

bnd options:

  ext.bndOptions = [
    "Export-Package": [
      "!*internal*",
      "reactor.*"
    ].join(","),
    "Import-Package": [
      "!javax.annotation",
      "*"
    ].join(","),
    "Bundle-Name" : "reactor-pool",
    "Bundle-SymbolicName" : "io.projectreactor.addons.reactor-pool"
  ]
@reactorbot reactorbot added the ❓need-triage This issue needs triage, hasn't been looked at by a team member yet label Aug 10, 2020
@simonbasle simonbasle added this to the 0.1.7.RELEASE milestone Aug 10, 2020
@ericbottard ericbottard self-assigned this Aug 10, 2020
ericbottard added a commit to ericbottard/reactor-pool that referenced this issue Aug 11, 2020
ericbottard added a commit that referenced this issue Aug 11, 2020
@simonbasle simonbasle added type/chore A task not related to code (build, formatting, process, ...) and removed ❓need-triage This issue needs triage, hasn't been looked at by a team member yet labels Oct 1, 2020
simonbasle added a commit that referenced this issue Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore A task not related to code (build, formatting, process, ...)
Projects
None yet
Development

No branches or pull requests

3 participants