fix #86 Add background eviction #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbasle
changed the title
Codecov Report
@@ Coverage Diff @@
## 0.1.x #100 +/- ##
============================================
- Coverage 83.56% 78.61% -4.96%
- Complexity 139 140 +1
============================================
Files 10 11 +1
Lines 639 692 +53
Branches 98 105 +7
============================================
+ Hits 534 544 +10
- Misses 75 116 +41
- Partials 30 32 +2
Continue to review full report at Codecov.
|
simonbasle
force-pushed
the
86-reaperThread
branch
from
9024893
to
57831af
Compare
This commit adds an option for background eviction of resources in case no activity is registered on the pool. Note that the background eviction is best effort, and will back off if there are concurrent release / acquire activity. The later actually checks the eviction predicate too, which allows for some amount of eviction to occur even if the background task has backed off.
simonbasle
force-pushed
the
86-reaperThread
branch
from
57831af
to
2e6f776
Compare
bsideup
reviewed
Oct 6, 2020
|
|
||
| public class SimpleDequePoolStressTest { | ||
|
|
||
| @JCStressTest | ||
| @Outcome(id = "1001, 2, 0, 0", expect = ACCEPTABLE, desc = "evicted, acquired second resource") |
There was a problem hiding this comment.
4 state variables make it really hard to reason about this test. Given that 1st and 3rd are always "1001" and "0", can't we get rid of them?
There was a problem hiding this comment.
I don't think so, no. Both these validate that the pool correctly released the resource and that the accounting is correct. Maybe put them as 3rd and 4th variable since slightly less interesting than the second one (acquired)
aneveu
approved these changes
Oct 7, 2020
violetagg
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.