-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] Split the publish workflow preparation to parallelize slow tests #145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
in the latest state, splits prepare (which includes shorter tests) vs races tests vs loops tests + jcstress. the longest is still the races-tagged tests, which run for about 9min on CI. This PR thus reduces the publish workflow by about 10min (was 19min). |
@OlegDokuka thanks for the review. Can you double check everything is fine and no testing-related changes are left? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes to make it working
.github/workflows/publish.yml
Outdated
java-version: 8 | ||
- name: run loop and stress tests | ||
id: loopsTests | ||
run: ./gradlew test -Pjunit-tags=loops jcstress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
run: ./gradlew test -Pjunit-tags=loops jcstress | |
run: ./gradlew test -Pjunit-tags=loops,slow jcstress |
ok so let me rework this a bit actually. since prepare + base tests + jcstress + loop tests take up about 10min, and race tests take about 9min (on CI), I think we can limit the number of parallel jobs to 2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ok, in the last execution we had:
I have verified that the test logs show the same number of passed tests (445) by combining the logs of the 2 jobs and comparing to the release's log, filtering on |
No description provided.